Drupal 11 #159
Drupal 11 #159
Conversation
| }, | ||
| "require-dev": { | ||
| "behat/behat": "^3.12", | ||
| "behat/mink-goutte-driver": "^2.0", |
There was a problem hiding this comment.
It sounds like we don't need this anymore. Is this correct?
https://packagist.org/packages/behat/mink-goutte-driver
Drupal already has https://packagist.org/packages/behat/mink-browserkit-driver as a requirement.
There was a problem hiding this comment.
Hmm. Maybe there's more to do here:
In GoutteFactory.php line 66:
Install MinkGoutteDriver in order to use goutte driver.
https://circleci.com/gh/palantirnet/drupal-skeleton/708
There was a problem hiding this comment.
Fixed by updating palantirnet/the-build@02cd8ee
|
This is exciting... I think we're going to need to update to Node 20 at least, if not Node 22. |
|
Tests are now passing with the changes from #160. While an update to Node 20 or 22 and Yarn 4 would be prudent, it is no longer blocking the D11 update. |
| @@ -46,7 +46,7 @@ hooks: | |||
| # This allows ddev to manage its own settings.ddev.php file. | |||
| disable_settings_management: false | |||
|
|
|||
| type: drupal10 | |||
| type: drupal11 | |||
There was a problem hiding this comment.
This change will require DDEV >=1.24.0
| "palantirnet/the-build": "^4@beta" | ||
| "drupal/core-dev": "^11", | ||
| "drupal/drupal-extension": "^5", | ||
| "palantirnet/the-build": "dev-drupal11" |
There was a problem hiding this comment.
TODO: Change this back to a stable version constraint after the drupal11 branch is merged into the-build, and there is a new release.
| @@ -7,14 +7,14 @@ name: drupal-skeleton | |||
|
|
|||
| # TODO: If the project uses Acquia hosting, use these settings. | |||
| docroot: docroot | |||
| mysql_version: "5.7" | |||
| mysql_version: "8.0" | |||
There was a problem hiding this comment.
@byrond The only question I have is how this is set. In another project I ran ddev debug migrate-database mysql:8.0 and I got the database setup like
database:
type: mysql
version: "8.0"
This as is worked and I build a D11 site so I guess this is fine. Just wanted to note the difference I saw.
|
@byrond I left a comment in the PR, everything looks good just adding a note. Once this is approved is there an order that this and palantirnet/the-build#237 should be merged in? Or is it ok to just merge both in. I know this pr sets the build to a specific version. Does that need to be updated before merging this in? |
User story: DEV-67: Update drupal-skeleton to Drupal 11
Description
Requires #156 and palantirnet/the-build#236
minimum-stabilityhas been set todevuntil a release ofdrupal-driversupports Symfony 7.Removes Workbench and Workbench Tabs until D11-compatible versions are available.Testing instructions
composer create-project palantirnet/drupal-skeleton example dev-drupal11 --no-interaction --no-installcomposer require --dev palantirnet/the-build:dev-drupal11Open questions
Delete this section if there are no open questions.
Remaining tasks
Delete this section if there are no remaining tasks.